Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Persist imported Mission Control Data across restarts [TEST] #11

Closed
wants to merge 2 commits into from

Conversation

mohamedawnallah
Copy link
Owner

Change Description

Description of change / link to associated issue.

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

  • Your PR passes all CI checks.
  • Tests covering the positive and negative (error paths) are included.
  • Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

📝 Please see our Contribution Guidelines for further guidance.

Copy link

github-actions bot commented Jul 7, 2024

Pull reviewers stats

Stats of the last 30 days for lnd:

User Total reviews Time to review Total comments

@mohamedawnallah mohamedawnallah force-pushed the persistAndResetMCDataOnDisk branch from f38eed4 to a731880 Compare July 7, 2024 16:24
@coveralls
Copy link

coveralls commented Jul 7, 2024

Pull Request Test Coverage Report for Build 9828262162

Details

  • 95 of 141 (67.38%) changed or added relevant lines in 2 files are covered.
  • 22857 unchanged lines in 399 files lost coverage.
  • Overall coverage decreased (-8.4%) to 49.886%

Changes Missing Coverage Covered Lines Changed/Added Lines %
routing/missioncontrol.go 17 22 77.27%
routing/missioncontrol_store.go 78 119 65.55%
Files with Coverage Reduction New Missed Lines %
routing/errors.go 1 94.74%
routing/graph.go 1 88.0%
lnwallet/parameters.go 1 91.67%
lnwire/typed_lease_expiry.go 2 78.95%
lnwire/typed_fee.go 2 66.67%
channeldb/forwarding_policy.go 2 85.14%
routing/chainview/queue.go 2 94.29%
lnwallet/musig_session.go 2 79.29%
record/hop.go 2 93.33%
lnwire/short_channel_id.go 2 89.74%
Totals Coverage Status
Change from base Build 9828197428: -8.4%
Covered Lines: 93897
Relevant Lines: 188223

💛 - Coveralls

@mohamedawnallah mohamedawnallah force-pushed the persistAndResetMCDataOnDisk branch from a731880 to 4ef0753 Compare July 7, 2024 16:33
@coveralls
Copy link

coveralls commented Jul 7, 2024

Pull Request Test Coverage Report for Build 9828779792

Details

  • 92 of 141 (65.25%) changed or added relevant lines in 2 files are covered.
  • 22833 unchanged lines in 397 files lost coverage.
  • Overall coverage decreased (-8.4%) to 49.894%

Changes Missing Coverage Covered Lines Changed/Added Lines %
routing/missioncontrol.go 13 21 61.9%
routing/missioncontrol_store.go 79 120 65.83%
Files with Coverage Reduction New Missed Lines %
routing/errors.go 1 94.74%
routing/graph.go 1 88.0%
signal/signal.go 1 75.0%
lnwallet/parameters.go 1 91.67%
lnwire/typed_lease_expiry.go 2 78.95%
lnwire/typed_fee.go 2 66.67%
channeldb/forwarding_policy.go 2 85.14%
routing/chainview/queue.go 2 94.29%
lnwallet/musig_session.go 2 79.29%
server.go 2 64.48%
Totals Coverage Status
Change from base Build 9828197428: -8.4%
Covered Lines: 93913
Relevant Lines: 188226

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants