Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modifying encoded maps and objects #254

Merged
merged 2 commits into from
Jul 14, 2021
Merged

Allow modifying encoded maps and objects #254

merged 2 commits into from
Jul 14, 2021

Conversation

joroKr21
Copy link
Collaborator

Maybe a bit controversial - in #247 I returned Collections.unmodifiableMap but later I realised that it's a perfectly valid use case to modify this map while building a larger encoder from smaller parts and in fact we do this in one place already.

@joroKr21 joroKr21 merged commit 4c858c0 into master Jul 14, 2021
@joroKr21 joroKr21 deleted the unmodifiable-map branch July 14, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants