Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed moiraapi class #560

Merged
merged 7 commits into from
Dec 4, 2024
Merged

removed moiraapi class #560

merged 7 commits into from
Dec 4, 2024

Conversation

EduardZaydler
Copy link
Member

@EduardZaydler EduardZaydler commented Nov 18, 2024 •
edited
Loading

PR Summary

  • replaced maintenance test with new playwright test
  • removed MoiraApi class with all deps
  • TriggerListItem, HeaderContainer, TriggerListDesktop are now function comps
  • completed rtk query methods

@EduardZaydler EduardZaydler requested a review from a team as a code owner November 18, 2024 06:36
@EduardZaydler
Copy link
Member Author

/build

@EduardZaydler
Copy link
Member Author

/build

sol-un
sol-un requested changes Nov 22, 2024
View reviewed changes
playwright/e2eTests/triggerOperations.spec.ts Outdated Show resolved Hide resolved
playwright/e2eTests/triggerOperations.spec.ts Outdated Show resolved Hide resolved
playwright/e2eTests/triggerOperations.spec.ts Outdated Show resolved Hide resolved
playwright/pages/triggerInfo.page.ts Show resolved Hide resolved
src/Components/MaintenanceSelect/MaintenanceSelect.tsx Show resolved Hide resolved
src/Components/TriggerListItem/TriggerListItem.tsx Show resolved Hide resolved
src/Containers/NotificationListContainer.tsx Outdated Show resolved Hide resolved
src/Containers/PatternListContainer.tsx Outdated Show resolved Hide resolved
src/Containers/TriggerEditContainer.tsx Show resolved Hide resolved
src/services/PatternsApi.ts Show resolved Hide resolved
@EduardZaydler
Copy link
Member Author

/build

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

Build and push Docker images with tag: 2024-12-04.f3f75ed

sol-un
sol-un previously approved these changes Dec 3, 2024
View reviewed changes
@EduardZaydler EduardZaydler merged commit f3f75ed into master Dec 4, 2024
3 checks passed
@EduardZaydler EduardZaydler deleted the chore/removing-moiraApi-class branch December 4, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flizzzzzard flizzzzzard flizzzzzard approved these changes

@sol-un sol-un sol-un left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EduardZaydler @sol-un @flizzzzzard