feat(mojaloop/#3524): add position fulfil to binprocessor #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feature/position-prepare-binnning
* feat: add position prepare bin logic * edit * lint * dep * chore: changes * chore: commet * lint * chore: refactor * chore: unit tests * chore: change * chore: comment * chore: test * chore: more test * chore: test? * chore: remove * chore: rework domain logic * chore: test * fix: position calculation * fix: position change data * fix; prepare domain function * chore: fix --------- Co-authored-by: Vijay <[email protected]>
* chore: add tests * chore: unit * sleep * chore: clear * chore: test * enum * fix: deadlock in tests --------- Co-authored-by: Vijay <[email protected]>
…mojaloop/central-ledger into feature/position-prepare-binnning
…te tests (#973) * chore: add tests * chore: unit * sleep * chore: clear * chore: test * enum * feat: add cached calls for participant currency * chore: change * chore: unit * chore: unit * lock * test * fix: unit test --------- Co-authored-by: Vijay <[email protected]>
kleyow
requested review from
mdebarros,
elnyry-sam-k and
vijayg10
as code owners
|
I'll add in the RESERVE funtionality after, this PR has ballooned enough. |
vijayg10
reviewed
Dec 8, 2023
vijayg10
reviewed
Dec 8, 2023
vijayg10
reviewed
Dec 8, 2023
vijayg10
reviewed
Dec 8, 2023
vijayg10
approved these changes
Dec 13, 2023
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(mojaloop/#3524): add position fulfil to binprocessor - mojaloop/project#3524