test: fix disconnect errors #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5bf58ac.
kalinkrustev
requested review from
mdebarros,
elnyry-sam-k and
kleyow
as code owners
|
vijayg10
approved these changes
Mar 28, 2024
kleyow
added a commit
that referenced
this pull request
Apr 2, 2024
* fix: cluster performance testing issues (#996) * test: fix disconnect errors (#998) * chore(release): 17.6.1 [skip ci] * chore: fix current tests * boolean * chore: add endpoints to test data * fix endpoint import * chore: improve validator coverage * chore: move prepare tests into file to match src structure --------- Co-authored-by: Kalin Krustev <[email protected]> Co-authored-by: mojaloopci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes multiple issues in the integration tests, that cause random disconnect errors.
Overall problem is that tests are using tape 4, while reading the source code gives a false impression that they use async/await, which is not true, as it is only supported in tape 5. Migration is not very easy, due to extensive use of .end() calls.
This fix is probably also resolving this issue mojaloop/project#3112