Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete mode to run Central-Ledger TigerBeetle mode ON without any duplicated data #3301

Closed
27 of 29 tasks
koekiebox opened this issue Apr 20, 2023 · 0 comments
Closed
27 of 29 tasks
Assignees
Labels
tigerbeetle All TigerBeetle related Mojaloop work. vNext vNext Platform Development (inline with RefArch) vNext-Settlement Stories and tasks related to the new Mojaloop Settlement component.

Comments

@koekiebox
Copy link

koekiebox commented Apr 20, 2023

Complete mode to run Central-Ledger TigerBeetle mode ON without any duplicated data (analyse impact on Central-Ledger Transfer tables)

central-ledger-schema-bigtick.png

Tasks to complete:

  • Replace internal TB in central-image with docker-compose setup and execute
  • Add health checks for docker-compose in order for wait-4-docker to check TB health status
  • Add TB init and shutdown hooks for all integration test cases
  • Simplify TB integration account creation (make use of participant=account.user_data and participantCurrency=account.id) instead of account id derivation
  • Add function to perform DNS lookups (TB does not currently support DNS lookups for the NodeJS client)
  • Add TB mode only tables for storing ILP packet, condition and fulfilment
  • Add TB mode only tables for storing transfer extensions
  • Add tb#lookupTransferMapped in order to convert TB transfer to MJL format
  • Add tb#lookupAccountMapped in order to convert TB participantCurrency to MJL format (and for DC/CR position balance)
  • Implement timeout status check for transfer (requires lookup of Transfer via transfer.pending_id) temporary workaround to be supplied here (until TB release in July2023). Function should look at flags to determine if the transfer was a void or a post (return status), options include: voided/posted/none (no action yet)
  • Port facade#getById enable TB mode only and respective test cases
  • Port transferDuplicateCheck enable TB mode only and respective test cases
  • Port transferFulfilmentDuplicateCheck enable TB mode only and respective test cases
  • Port facade#getByIdLight enable TB mode only and respective test cases
  • Port facade#getAll enable TB mode only (low priority) NOT GOING TO IMPLEMENT - Limitation.
  • Port facade#getTransferInfoToChangePosition enable TB mode only (disable due to TB auto position)
  • Port facade#savePayeeTransferResponse enable TB mode only
  • Port facade#saveTransferPrepared enable TB mode only
  • Port facade#getTransferStateByTransferId enable TB mode only (Only pending/posted/voided), no need for a state machine
  • Port facade#timeoutExpireReserved enable TB mode only. Require listing of expired transfers.
  • Port facade#transferStateAndPositionUpdate enable TB mode only
  • Port facade#reconciliationTransferPrepare enable TB mode only - part of funds in
  • Port facade#reconciliationTransferReserve enable TB mode only - part of funds in
  • Port facade#reconciliationTransferCommit enable TB mode only - part of funds in
  • Port facade#reconciliationTransferAbort enable TB mode only - part of funds in
  • Port facade#recordFundsIn enable TB mode only - part of funds in
  • Port facade#getTransferParticipant enable TB mode only
  • Update caller clients to be compatible with TB mode only (☝️)
  • Update integration tests to pass with TB+DB mode on

Relates to:

#3300

PR:

mojaloop/central-ledger#956

@koekiebox koekiebox added the tigerbeetle All TigerBeetle related Mojaloop work. label Apr 20, 2023
@koekiebox koekiebox self-assigned this May 26, 2023
@JaneS321 JaneS321 added vNext vNext Platform Development (inline with RefArch) vNext-Settlement Stories and tasks related to the new Mojaloop Settlement component. labels Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tigerbeetle All TigerBeetle related Mojaloop work. vNext vNext Platform Development (inline with RefArch) vNext-Settlement Stories and tasks related to the new Mojaloop Settlement component.
Projects
None yet
Development

No branches or pull requests

2 participants