Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for multimodule-module-with-parent there is a missing direct-dependency test case #220

Closed
KemalSoysal opened this issue Jul 1, 2021 · 1 comment · Fixed by #329
Closed

for multimodule-module-with-parent there is a missing direct-dependency test case #220

KemalSoysal opened this issue Jul 1, 2021 · 1 comment · Fixed by #329

Comments

@KemalSoysal
Copy link
Contributor

We ran into an issue with dependencies of parent being flattened into the multimodule-module-with-parent when configured with flattenDependencyMode direct (default and explicit).

I checked the integration test scenarios and found out, it is missing.

I duplicated and adapted the multimodule-module-with-parent test from resolveCiFriendliesOnly locally, and it shows the same behavior as in production.
@KemalSoysal
Copy link
Contributor Author

It turned out that

  • inherit-parent-dependency
  • parent-with-version-range

were configured default to flattenDependencyMode direct by default.

They also failed after implementing the bug fix for #220

KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Jul 8, 2021
@KemalSoysal
mojohaus#220 add missing direct-dependency test case for
35aaea8 
multimodule-module-with-parent
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Jul 8, 2021
@KemalSoysal
mojohaus#220 add temporarily remote debug and test just direct depend…
f842535 
…ency test

case
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Jul 8, 2021
@KemalSoysal
mojohaus#220 implement DirectDependenciesInheritanceAssembler
1c24f5e 
to provide FlattenDependencyMode to the
DirectDependenciesInheritanceModelMerger to decide if the parent
dependencies should be merged into the child.
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Jul 8, 2021
@KemalSoysal
Revert "mojohaus#220 add temporarily remote debug and test just direc…
49619dc 
…t dependency test"

This reverts commit f842535.
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Jul 8, 2021
@KemalSoysal
mojohaus#220 update the test case inherit-parent-dependency to
4d26c3a 
flattenDependencyMode all
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Jul 8, 2021
@KemalSoysal
mojohaus#220 update the test case parent-with-version-range to
3b61a3e 
flattenDependencyMode all
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Jul 8, 2021
@KemalSoysal
mojohaus#220 add contributors
f97105a
@slawekjaranowski slawekjaranowski linked a pull request Nov 15, 2022 that will close this issue
Bugfix/220 #221
Closed
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 use two spaces for indentation as in other files
74d38f3
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 remove commented flattenMode configuration
5e97b3b
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 remove manual sisu configuration, add sisu-maven-plugin …
0e63c29 
…to accomplish the job
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 remove superfluous @specializes
d2f45da
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 add missing direct-dependency test case for
a82d03f 
multimodule-module-with-parent
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 implement DirectDependenciesInheritanceAssembler
c7905ac 
to provide FlattenDependencyMode to the
DirectDependenciesInheritanceModelMerger to decide if the parent
dependencies should be merged into the child.
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 update the test case inherit-parent-dependency to
8f084e3 
flattenDependencyMode all
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 update the test case parent-with-version-range to
bf64ca6 
flattenDependencyMode all
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 add contributors
7ed18e6
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 Include ASL and author Ralf Lübeck
7cc4de0
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 Update DirectDependenciesInheritanceAssembler.java
26611e7 
add class documentation to the issue and the need for the class and configuration hint
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 use two spaces for indentation as in other files
66eaf01
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 remove commented flattenMode configuration
344a49b
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 remove manual sisu configuration, add sisu-maven-plugin …
ddd8519 
…to accomplish the job
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 remove superfluous @specializes
b02e35d
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Nov 30, 2022
@KemalSoysal
mojohaus#220 resolve check style issues after rebasing/cherry-picking…
ec2543d 
… on top of master
@KemalSoysal KemalSoysal mentioned this issue Nov 30, 2022
Merged
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Dec 5, 2022
@KemalSoysal
mojohaus#220 move the sisu-maven-plugin to the build section
00ced9e
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Dec 5, 2022
@KemalSoysal
mojohaus#220 using the APT processor from the org.eclipse.sisu.inject…
ebf93f9 
… artifact is faster than using the sisu-maven-plugin
@slawekjaranowski slawekjaranowski linked a pull request Dec 5, 2022 that will close this issue
Fix #220 - multimodule-module-with-parent there is a missing direct-dependency #329
Merged
KemalSoysal added a commit to ls-it-solutions/flatten-maven-plugin that referenced this issue Dec 6, 2022
@KemalSoysal
mojohaus#220 move contributors to the contributors tag
1b4c967
slawekjaranowski pushed a commit that referenced this issue Dec 6, 2022
@KemalSoysal
Fix #220 - multimodule-module-with-parent there is a missing direct-d…
aab4485 
…ependency (#329)
@hkampbjorn hkampbjorn mentioned this issue May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@KemalSoysal