Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create typescript definitions #37

Open
dgileadi opened this issue Dec 22, 2015 · 4 comments
Open

Create typescript definitions #37

dgileadi opened this issue Dec 22, 2015 · 4 comments

Comments

@dgileadi
Copy link

Some tools (like Visual Studio Code) can use typescript definitions for code insight and completion. Many popular JS libraries already have typescript definitions. It would be really nice to have typescript definitions for js-must too.

In any case thanks for a great library!

@moll
Copy link
Owner

moll commented Dec 22, 2015

👍

I was thinking of some just today while giving Flow a try. Perhaps it's possible to autogenerate both from inline documentation...

@moll
Copy link
Owner

moll commented Jul 22, 2016

@dgileadi: @KarlPurk added some type definitions. Would you mind giving them a spin, too?

@moll
Copy link
Owner

moll commented Jul 22, 2016

Let's carry on from #48 here, @KarlPurk.

👍 for the tests, too. What do you have in mind? I can imagine positive cases are easy to test — everything in some file has to pass. How would you do negative ones? "This file has to have this number of failures"? Or maybe negative cases here are too much work for little benefit.

@KarlPurk
Copy link
Contributor

Yes I think there's little benefit to negative testing, the main value in testing the definition file is to make sure it covers the API fully (and correctly) so we likely just need to test the happy path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants