Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading words about should.js in README #60

Open
btd opened this issue Feb 28, 2017 · 4 comments
Open

Misleading words about should.js in README #60

btd opened this issue Feb 28, 2017 · 4 comments

Comments

@btd
Copy link

btd commented Feb 28, 2017

Hello.

I am a should.js maintainer and everything you described in README was covered in should.js even before must.js was created. Could you please remove should.js parts to do not mislead users?

@moll
Copy link
Owner

moll commented Feb 28, 2017

So everything is a function now in Should.js? I'm quite certain back in the day the foo.should.be.false assertion-style existed.

@btd
Copy link
Author

btd commented Feb 28, 2017

Yes, i know about such problem, i was thinking about it almost from begining of maintainance.
I tried a lot of things first to avoid breaking change (like adding plugins to jshtin/eslint, proxies to assert on non existing propety access), but eventually decide to make this breaking change - nobody complained about it.

@moll
Copy link
Owner

moll commented Feb 28, 2017

That's good. Since what version did you fix this? I'll make a note of that in the README that what I said applies only to previous versions. ;)

@btd
Copy link
Author

btd commented Feb 28, 2017

It is safe to assume since 7.0.0 (current 11.x.y). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants