Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package-lock.json file for administration and storefront npm install #219

Closed
AndreasA opened this issue Oct 29, 2021 · 2 comments
Closed

Comments

@AndreasA
Copy link

With current shopware production template all plugin dependencies call a npm install for all installed plugins in admin and storefront build processes:
https://github.com/shopware/production/blob/v6.4.5.1/bin/build-storefront.sh#L32

This means that the npm install is triggered and currently there is no package-lock.json so it might result in wrong dependency versions being installed.

However, I think the installation isn't required at all, see: #217

@boxblinkracer
Copy link
Collaborator

Hi

thank you for this

yes you are right
at the moment theres no lock file.
might have been missed in git

ill add it :)
should definitely be in there

@boxblinkracer
Copy link
Collaborator

locks are now existing in the main branch in the upstream :)
thank you for reporting this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants