From 9ec3f4bf4f7f870f11aa139195f0fdd9c46917d4 Mon Sep 17 00:00:00 2001 From: Michiel Gerritsen Date: Mon, 20 Nov 2023 15:35:46 +0100 Subject: [PATCH] Bugfix: Refund zero shipping refunds #720 --- Model/Client/Orders.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Model/Client/Orders.php b/Model/Client/Orders.php index fe796344c80..d4d16477995 100644 --- a/Model/Client/Orders.php +++ b/Model/Client/Orders.php @@ -744,7 +744,7 @@ public function createOrderRefund(Order\Creditmemo $creditmemo, Order $order) * Check if Shipping Fee needs to be refunded. * Throws exception if Shipping Amount of credit does not match Shipping Fee of paid orderLine. */ - $addShippingToRefund = null; + $addShippingToRefund = false; $shippingCostsLine = $this->orderLines->getShippingFeeItemLineOrder($orderId); if ($shippingCostsLine->getId() && $shippingCostsLine->getQtyRefunded() == 0) { if ($creditmemo->getShippingAmount() > 0) { @@ -757,7 +757,7 @@ public function createOrderRefund(Order\Creditmemo $creditmemo, Order $order) } } - $shouldRefund = $addShippingToRefund || !$creditmemo->getAllItems(); + $shouldRefund = $addShippingToRefund || $creditmemo->getAllItems(); if (!$shouldRefund || $this->adjustmentFee->doNotRefundInMollie()) { return $this; }