Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancelUrl in payment.create as specified in the documentation #332

Closed
Alexandregirbal opened this issue Oct 20, 2023 · 7 comments
Closed
Assignees
Labels
API discrepancy Inconsistency between Mollie's REST API and this SDK.
Milestone

Comments

@Alexandregirbal
Copy link

In the documentation of the Create payment route there is an optional paramter named cancelUrl. It is not a parameter of the payments.create method in this client.

@madhums
Copy link

madhums commented Oct 25, 2023

Yes, much needed.

@Alexandregirbal
Copy link
Author

I had another look and this have been fix with PR #327 which was merged on master on the 27th of September.
Unfortunately the NPM package wasn't published for 7 months now. @Pimm or @vernondegoede any news for a release date on npm? 😄
Maybe we should build the client locally until then ?

@fjbender
Copy link
Contributor

Indeed, I think a fresh release would be in order. @Pimm would you feel comfortable tagging the current state as a new release? The change set looks quite serious.

@Alexandregirbal
Copy link
Author

@Pimm Any news about this topic? otherwise the npm package is useless to many of us I guess as the issue forces us to use the raw api.

@fjbender
Copy link
Contributor

fjbender commented Jan 9, 2024

@janpaepke , @Pimm , @maria-swierblewska , and I are currently solving Node version compatibility in #338 (as that also has connections to an Axios CVE). After that is solved, I'm confident we'll be able to push out a release soon.

@Alexandregirbal
Copy link
Author

Ok thanks a lot!

@Pimm Pimm self-assigned this Aug 1, 2024
@janpaepke janpaepke added the API discrepancy Inconsistency between Mollie's REST API and this SDK. label Sep 11, 2024
@janpaepke
Copy link
Collaborator

This was fixed in ce5e5d0 and released as part of 4.0.0-beta.

Version 4.0.0 will also be released soon.

@janpaepke janpaepke added this to the 4.0.0 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API discrepancy Inconsistency between Mollie's REST API and this SDK.
Projects
None yet
Development

No branches or pull requests

5 participants