Language in Firefox

[BNYBLN030]

the Language for Firefox with de_DE.csv doesnt work! In IE it works automatically ...
should I change something in the config?

[eljeffeg]

So, this is a bug in Tornado itself. tornadoweb/tornado#1858
I'll write a work around since it was reported in 2016 and they haven't fixed it. Essentially the browser is returning de as an acceptable language and Tornado should choose the closest match, which is de_DE, but since it's not exact, it falls back to english. This is in contrast to what their documentation says it should do.

[eljeffeg]

I've submitted a pull request to Tornado with a fix. I'm not sure if I should create a work around in RootTheBox (easy to do) or mark this pending a Tornado update. @moloch-- thoughts?

I could add this code to BaseHandler in get_user_locale():

codes = self.request.headers.get("Accept-Language")
if codes:
    for code in codes.split(","):
        code = code.split(";")[0]
        for l in locale.get_supported_locales():
            if code.lower() == l.split("_")[0]:
                return locale.get(l)

[eljeffeg]

Pushed up a temporary fix, since the Tornado folks have not commented on the issue or pull request.