Inconsistency in response type handling for GetBatch and SetBatch API methods

[Takashicc]

When handling the results after calling (momento.CacheClient) GetBatch, I attempted to handle it as follows:

result, err := momentoClient.GetBatch(ctx, &momento.GetBatchRequest{
    CacheName: cacheName,
    Keys:      keys,
})
if err != nil {
    return nil, err
}

switch val := result.(type) {
case *responses.GetBatchSuccess:
    return val.ValueMap(), nil
default:
    return nil, fmt.Errorf("unexpected response type: %T", val)
}

However, since the type returned by GetBatch is not a pointer, it seems that I need to use case responses.GetBatchSuccess instead. This behavior differs from other APIs where the handling is done with pointers.
I have noticed the same behavior with SetBatch as well.

• GetBatch

  • client-sdk-go/momento/get_batch.go

    Line 83 in a8f5e04

    r.response = *responses.NewGetBatchSuccess(getResponses, r.byteKeys)

• SetBatch

  • client-sdk-go/momento/set_batch.go

    Line 85 in a8f5e04

    r.response = *responses.NewSetBatchSuccess(setResponses)