New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when user passes undefined to our unary methods, we throw an error due to trace logging #1056

Open

bruuuuuuuce opened this issue Nov 22, 2023 · 0 comments

Labels

customer request

Contributor

bruuuuuuuce commented Nov 22, 2023 •

edited

Loading

This happens when using pure javascript

        this.logger.trace(`Issuing 'get' request; key: ${key.toString()}`);
                                                             ^

TypeError: Cannot read properties of undefined (reading 'toString')

Should return an instance of CacheGet.Error

Validation would go around here https://github.com/momentohq/client-sdk-javascript/blob/main/packages/client-sdk-nodejs/src/internal/cache-data-client.ts#L291-L295

The text was updated successfully, but these errors were encountered:

bruuuuuuuce added the customer request label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment