Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add incr api #28

Merged
merged 2 commits into from
May 2, 2024
Merged

feat: add incr api #28

merged 2 commits into from
May 2, 2024

Conversation

rishtigupta
Copy link
Contributor

@rishtigupta rishtigupta commented May 1, 2024 •
edited
Loading

PR Description:

  • Add incr operation + tests
  • Remove node 14, and add node 20 for ci tests

Issue:

https://github.com/momentohq/dev-eco-issue-tracker/issues/802

@rishtigupta rishtigupta marked this pull request as ready for review May 1, 2024 23:04
cprice404
cprice404 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clap

@rishtigupta rishtigupta merged commit 32d7817 into main May 2, 2024
9 checks passed
@rishtigupta rishtigupta deleted the feat/incr branch May 2, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprice404 cprice404 cprice404 approved these changes

@eaddingtonwhite eaddingtonwhite Awaiting requested review from eaddingtonwhite

@malandis malandis Awaiting requested review from malandis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rishtigupta @cprice404