Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Synonym Sync: -confirmed has non-exact entries #687

Closed
twhetzel opened this issue Nov 15, 2024 · 1 comment · Fixed by #695
Closed

Bug: Synonym Sync: -confirmed has non-exact entries #687

twhetzel opened this issue Nov 15, 2024 · 1 comment · Fixed by #695
Assignees
@joeflack4
Labels
bug Something isn't working priority

Comments

@twhetzel
Copy link
Contributor

There are two Mondo terms where the Synonym Sync pipeline adds source evidence for a confirmed synonym where the Synonym Sync pipeline should not. These Mondo terms from the qc check are:

http://purl.obolibrary.org/obo/MONDO_0012817,Ewing sarcoma,NCIT:C7542,PNET of Thoracopulmonary region,MONDO:relatedTo
http://purl.obolibrary.org/obo/MONDO_0002514,hepatobiliary neoplasm,DOID:3117,hepatobiliary tumors,MONDO:mondoIsBroaderThanSource

These should be sorted out with high priority to resolve this issue, but it is not blocking the existing work on the Synonym Sync pipeline from being merged and getting into main. So #93 and #671 should be merged before working on this at this time.
@twhetzel twhetzel added bug Something isn't working priority labels Nov 15, 2024
@twhetzel twhetzel mentioned this issue Nov 15, 2024
Closed
@joeflack4 joeflack4 changed the title Synonym sync adding source evidence incorrectly Bug: Synonym Sync: -confirmed has non-exact entries Nov 17, 2024
@joeflack4 joeflack4 linked a pull request Nov 20, 2024 that will close this issue
Bug fix: Synonym Sync: Entries without exact mappings #695
Merged
9 tasks
This was referenced Nov 20, 2024
Merged
Closed
Closed
@joeflack4
Copy link
Contributor

resolved by:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeflack4 joeflack4

Labels
bug Something isn't working priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix: Synonym Sync: Entries without exact mappings monarch-initiative/mondo-ingest
2 participants
@twhetzel @joeflack4