Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Windows Package Installation to allow aws_ssm and other connection types #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

s256
Copy link

@s256 s256 commented Nov 26, 2024

The current installation logic requires our target machine to have internet access, which is not always the case.
In addition, win_package with a URL as Path doesn't seem to work with aws_ssm even though the machine has internet access.
I changed the behaviour to match from what I saw at the sentinelOne collection.
This fixes #83

Copy link

Thank you for your submission. We really appreciate it. Before we can accept your contribution, we ask that you sign the Mondoo Contributor License Agreement. You can sign the CLA by adding a new comment to this pull request and pasting exactly the following text.


I have read the Mondoo CLA Document and I hereby sign the CLA


Sebastian Noe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

- name: Ensure we have the latest os provider installed
ansible.windows.win_command: cnspec providers install os
args:
chdir: "C:\\Program Files\\Mondoo"
when: not ansible_check_mode and cnspec_version.stdout is match(".*cnspec 9.*")
when: not ansible_check_mode and cnspec_version.stdout is match(".*cnspec 11.*")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: provider install/update would fail in an air-gapped environment as well

Copy link
Contributor

@philipbalinov philipbalinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @s256!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails on Windows via aws_ssm
2 participants