From 44067c748510c89fb9171392f628f373cac89657 Mon Sep 17 00:00:00 2001 From: Tim Smith Date: Mon, 23 Dec 2024 12:43:14 -0800 Subject: [PATCH] Minor spellcheck updates Fixes detected by a rule that didn't quite work out Signed-off-by: Tim Smith --- .github/actions/spelling/line_forbidden.patterns | 1 + mql/internal/execution_manager.go | 2 +- providers-sdk/v1/lr/lr.go | 2 +- providers/aws/connection/connection.go | 2 +- providers/aws/resources/discovery.go | 2 +- providers/aws/resources/discovery_conversion.go | 2 +- 6 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/actions/spelling/line_forbidden.patterns b/.github/actions/spelling/line_forbidden.patterns index 76df69d95c..dc8c9ac742 100644 --- a/.github/actions/spelling/line_forbidden.patterns +++ b/.github/actions/spelling/line_forbidden.patterns @@ -329,6 +329,7 @@ # s.b. Microsoft IIS \bIIS Server\b + # # VMware Products # diff --git a/mql/internal/execution_manager.go b/mql/internal/execution_manager.go index 363a297dfb..096c9a9917 100644 --- a/mql/internal/execution_manager.go +++ b/mql/internal/execution_manager.go @@ -75,7 +75,7 @@ func (em *executionManager) Start() { if r.Error != "" { // This case is tricky to handle. If we cannot run the query at // all, its unclear what to report for the datapoint. If we - // report them in, then another query cant report them, at least + // report them in, then another query can't report them, at least // with the way things are right now. If we don't report them, // things will wait around for datapoint results that will never // arrive. diff --git a/providers-sdk/v1/lr/lr.go b/providers-sdk/v1/lr/lr.go index 42315666ed..cf651a7d4c 100644 --- a/providers-sdk/v1/lr/lr.go +++ b/providers-sdk/v1/lr/lr.go @@ -283,7 +283,7 @@ func Parse(input string) (*LR, error) { name = *f.Embeddable.Alias } else { // use the first part of the type name as a id, i.e. os for os.any - // this wont work if there're are multiple embedded resources without aliases that share the same package, i.e os.any and os.base + // this won't work if there're are multiple embedded resources without aliases that share the same package, i.e os.any and os.base name = strings.Split(f.Embeddable.Type, ".")[0] } newField := &Field{ diff --git a/providers/aws/connection/connection.go b/providers/aws/connection/connection.go index 583cbbd8d7..fde629f428 100644 --- a/providers/aws/connection/connection.go +++ b/providers/aws/connection/connection.go @@ -182,7 +182,7 @@ func parseOptsToFilters(opts map[string]string) DiscoveryFilters { } func parseFlagsForConnectionOptions(m1 map[string]string, m2 map[string]string, creds []*vault.Credential) []ConnectionOption { - // merge the options to make sure we dont miss anything + // merge the options to make sure we don't miss anything m := m1 if m == nil { m = make(map[string]string) diff --git a/providers/aws/resources/discovery.go b/providers/aws/resources/discovery.go index 10abb493e7..c181e11bc7 100644 --- a/providers/aws/resources/discovery.go +++ b/providers/aws/resources/discovery.go @@ -170,7 +170,7 @@ func handleTargets(targets []string) []string { // for now we have to post process the filters // more ideally, we should pass the filters in when discovering -// so that we dont unnecessarily discover assets we will later discard +// so that we don't unnecessarily discover assets we will later discard func discover(runtime *plugin.Runtime, awsAccount *mqlAwsAccount, target string, filters connection.DiscoveryFilters) ([]*inventory.Asset, error) { conn := runtime.Connection.(*connection.AwsConnection) accountId := trimAwsAccountIdToJustId(awsAccount.Id.Data) diff --git a/providers/aws/resources/discovery_conversion.go b/providers/aws/resources/discovery_conversion.go index 7d976f466b..cfa2a8dbb2 100644 --- a/providers/aws/resources/discovery_conversion.go +++ b/providers/aws/resources/discovery_conversion.go @@ -342,7 +342,7 @@ func addConnectionInfoToEc2Asset(instance *mqlAwsEc2Instance, accountId string, Type: vault.CredentialType_aws_ec2_ssm_session, }) } else { - // if we dont have a connection already, we need to add one + // if we don't have a connection already, we need to add one creds := []*vault.Credential{ { User: probableUsername,