🐛 fix platform detection override for lr docs (#2226)

providers-sdk/v1/lr/cli/cmd/docs.go

@@ -146,6 +146,11 @@ var docsYamlCmd = &cobra.Command{
 	},
 }
 
+// required to be before more detail platform to ensure the right mapping
+var platformMappingKeys = []string{
+	"aws", "gcp", "k8s", "azure", "azurerm", "arista", "equinix", "ms365", "msgraph", "vsphere", "esxi", "terraform", "terraform.state", "terraform.plan",
+}
+
 var platformMapping = map[string][]string{
 	"aws":             {"aws"},
 	"gcp":             {"gcp"},
@@ -158,13 +163,13 @@ var platformMapping = map[string][]string{
 	"msgraph":         {"microsoft365"},
 	"vsphere":         {"vmware-esxi", "vmware-vsphere"},
 	"esxi":            {"vmware-esxi", "vmware-vsphere"},
+	"terraform":       {"terraform-hcl"},
 	"terraform.state": {"terraform-state"},
 	"terraform.plan":  {"terraform-plan"},
-	"terraform":       {"terraform-hcl"},
 }
 
 func ensureDefaults(id string, entry *docs.LrDocsEntry, version string) *docs.LrDocsEntry {
-	for k := range platformMapping {
+	for _, k := range platformMappingKeys {
 		if entry == nil {
 			entry = &docs.LrDocsEntry{}
 		}
@@ -178,7 +183,6 @@ func ensureDefaults(id string, entry *docs.LrDocsEntry, version string) *docs.Lr
 			entry.Platform = &docs.LrDocsPlatform{
 				Name: platformMapping[k],
 			}
-			continue // required to ensure that terraform.state is not overwritten by terraform
 		}
 	}
 	return entry

providers-sdk/v1/lr/cli/cmd/docs_test.go

@@ -0,0 +1,29 @@
+// Copyright (c) Mondoo, Inc.
+// SPDX-License-Identifier: BUSL-1.1
+
+package cmd
+
+import (
+	"github.com/stretchr/testify/assert"
+	"go.mondoo.com/cnquery/v9/providers-sdk/v1/lr/docs"
+	"testing"
+)
+
+var defaultLrDocsEntry = &docs.LrDocsEntry{
+	Fields:           map[string]*docs.LrDocsField{},
+	MinMondooVersion: "9.1.0",
+}
+
+func TestPlatformMapping(t *testing.T) {
+	res := ensureDefaults("terraform.plan.configuration", defaultLrDocsEntry, "9.1.0")
+	assert.Equal(t, "terraform-plan", res.Platform.Name[0])
+
+	res = ensureDefaults("terraform.plan.proposedChange", defaultLrDocsEntry, "9.1.0")
+	assert.Equal(t, "terraform-plan", res.Platform.Name[0])
+
+	res = ensureDefaults("terraform.state.module", defaultLrDocsEntry, "9.1.0")
+	assert.Equal(t, "terraform-state", res.Platform.Name[0])
+
+	res = ensureDefaults("terraform.block", defaultLrDocsEntry, "9.1.0")
+	assert.Equal(t, "terraform-hcl", res.Platform.Name[0])
+}

providers/terraform/resources/terraform.lr.manifest.yaml

@@ -154,7 +154,7 @@ resources:
     min_mondoo_version: 6.11.0
     platform:
       name:
-      - terraform-hcl
+      - terraform-state
   terraform.state.module:
     fields:
       address: {}
@@ -163,7 +163,7 @@ resources:
     min_mondoo_version: 6.11.0
     platform:
       name:
-      - terraform-hcl
+      - terraform-state
   terraform.state.output:
     fields:
       identifier: {}