Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 detect asset kind #1818

Merged
merged 1 commit into from
Sep 21, 2023
Merged

🐛 detect asset kind #1818

merged 1 commit into from
Sep 21, 2023

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Sep 21, 2023

Fixes #1691

@arlimus arlimus requested a review from tas50 September 21, 2023 01:29
@tas50
Copy link
Member

tas50 commented Sep 21, 2023

Is it possible to add a test for this fallback?

chris-rock
chris-rock approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @arlimus

@chris-rock
Copy link
Member

Is it possible to add a test for this fallback?

We are going to add more integration test to cover this case in the future.

@arlimus
🐛 detect asset kind
872ee5a 
Fixes #1691

Signed-off-by: Dominik Richter <[email protected]>
@arlimus arlimus merged commit a1d29a9 into main Sep 21, 2023
@arlimus arlimus deleted the dom/kind branch September 21, 2023 08:10
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chris-rock chris-rock chris-rock approved these changes

@tas50 tas50 Awaiting requested review from tas50

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v9 asset missing asset.kind and asset.name data
3 participants
@arlimus @tas50 @chris-rock