Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure real error is returned when doing multi-asset scan #1848

Closed
vjeffrey opened this issue Sep 22, 2023 · 4 comments
Closed

ensure real error is returned when doing multi-asset scan #1848

vjeffrey opened this issue Sep 22, 2023 · 4 comments
Labels
bug Something isn't working p2 Priority 2 v9.1

Comments

@vjeffrey
Copy link
Contributor

we had an issue with this in v8,
https://github.com/mondoohq/cnquery/blob/v8/explorer/scan/local_scanner.go#L167

@vjeffrey vjeffrey added the v9 label Sep 22, 2023
@chris-rock chris-rock added this to the v9 milestone Sep 23, 2023
@czunker
Copy link
Contributor

czunker commented Sep 25, 2023

This works diffently now and looks good to me:
https://github.com/mondoohq/cnquery/blob/main/explorer/scan/local_scanner.go#L186-L192

@vjeffrey
Copy link
Contributor Author

oh interesting. that would solve this problem, but i think we're gonna have to change that - we've generally wanted to not fail out the whole scan if we can't scan one thing - it's too restrictive

@vjeffrey
Copy link
Contributor Author

oh ya, there's actually a comment about that down below:

// TODO: we want to keep better track of errors, since there may be
		// multiple assets coming in. It's annoying to abort the scan if we get one
		// error at this stage.

@arlimus arlimus self-assigned this Sep 27, 2023
@arlimus arlimus added v9.1 and removed v9 labels Sep 27, 2023
@arlimus arlimus removed this from the v9 milestone Sep 27, 2023
@vjeffrey vjeffrey added the p0 Priority 0 label Oct 13, 2023
@czunker czunker self-assigned this Oct 17, 2023
czunker added a commit that referenced this issue Oct 17, 2023
@arlimus arlimus removed the p0 Priority 0 label Oct 23, 2023
@vjeffrey vjeffrey added the bug Something isn't working label Nov 27, 2023
@arlimus arlimus added the p2 Priority 2 label Dec 18, 2023
@chris-rock
Copy link
Member

fixed by #3152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p2 Priority 2 v9.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants