Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9 mql evaluation behaviour change for sshd.config.ciphers == null #1874

Closed
chris-rock opened this issue Sep 24, 2023 · 1 comment
Closed
Labels
Milestone

Comments

@chris-rock
Copy link
Member

Describe the bug

The evaluation of sshd.config.ciphers == null has changed in v9 compared to v9. In general I find the behavior in v9 more correct, but I'd like to ensure we have consensus about the behavior.

v8:

cnquery> sshd.config.ciphers
sshd.config.ciphers: []
cnquery> sshd.config.ciphers == null
[ok] value: []
cnquery> sshd.config.ciphers != null
[failed] sshd.config.ciphers != null
  expected: != _
  actual:   []

v9:

cnquery> sshd.config.ciphers
sshd.config.ciphers: []
cnquery> sshd.config.ciphers == null
[failed] sshd.config.ciphers == null
  expected: == _
  actual:   []
cnquery> sshd.config.ciphers != null
[ok] value: []

To Reproduce

run cnquery / cnspec with an sshd config where no ciphers are defined.

Expected behavior

tbd.

Desktop (please complete the following information):

cnquery v9.0.0-beta3 (d3f44c0, unknown)

@chris-rock chris-rock added the v9 label Sep 24, 2023
@chris-rock chris-rock added this to the v9 milestone Sep 24, 2023
@arlimus
Copy link
Member

arlimus commented Sep 25, 2023

Great catch, thanks for bringing it up!

v9 definitely is more consistent with the behavior we want.

Additionally, we'll introduce empty to better handle this concept in the future.

Closing this for now, referencing: #1884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants