Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix k8s.ingress certificates #1937

Merged
merged 3 commits into from
Sep 27, 2023
Merged

🐛 Fix k8s.ingress certificates #1937

merged 3 commits into from
Sep 27, 2023

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Sep 26, 2023

Fixes #1867

@czunker
🐛 Fix k8s.ingress certificates
7bd275c 
Fixes #1867

Signed-off-by: Christian Zunker <[email protected]>
@czunker
Copy link
Contributor Author

czunker commented Sep 26, 2023

This works now with Ingress objects which have and don't have TLS certificates configured:

cnquery run k8s --discover ingresses -c "k8s.ingress.tls.all( certificates.all( expiresIn.days > 15 ) )"
! using builtin provider for k8s
→ loaded configuration from /etc/opt/mondoo/mondoo.yml using source default
! using builtin provider for k8s
[ok] value: true

@czunker czunker marked this pull request as draft September 27, 2023 04:22
@czunker
Re-use mqlK8s resource
bff0ff3 
Signed-off-by: Christian Zunker <[email protected]>
@czunker czunker marked this pull request as ready for review September 27, 2023 06:42
arlimus
arlimus approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@arlimus arlimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the update!

@czunker
Fix review
0d36bb4 
Signed-off-by: Christian Zunker <[email protected]>
@czunker czunker merged commit faed5ce into main Sep 27, 2023
10 checks passed
@czunker czunker deleted the christian/v9_fix_k8s_ingress branch September 27, 2023 07:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arlimus arlimus arlimus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

k8s scan compare results
2 participants
@czunker @arlimus