Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ensure aws ebs scan cleans up after itself #1961

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Conversation

vjeffrey
Copy link
Contributor

fixes #1847

i don't love what i had to do to actually have all the info i needed to complete the shutdown - i had to copy a bunch of information that is usually on the provider to the asset connection options bc i was losing all the info on the provider by the time i get here...

cnquery> asset { platform version ids }
DBG starting query execution qrid=EmKggjLCPHY=
DBG finished query execution qrid=EmKggjLCPHY=
DBG bQqpVQgYCCh7C/Xkwh4dH/57nw0MiMSTXN4GoxUJz4PeyJsL2T2yg81qBXbpX9TR+kRYRrEBOCJfeiDkxt4LRg== finished
DBG graph has received all datapoints
asset: {
  version: "22.04"
  platform: "ubuntu"
  ids: [
    0: "//platformid.api.mondoo.app/runtime/aws/ec2/v1/accounts/367400545713/regions/us-east-1/instances/i-09739098c40b6df84"
  ]
}
cnquery> exit
DBG close aws ebs connection
DBG unmount volume dir=/tmp/cnspec-scan2100575520
→ detach volume
→ waiting for volume detachment completion state=available
DBG remove created dir dir=/tmp/cnspec-scan2100575520
→ delete created volume
→ deleted temporary volume created by Mondoo vol-id=vol-0b5ab2f2f22a3e4fb
[root@ip-172-31-38-240 ec2-user]#

@vjeffrey
Copy link
Contributor Author

the license check is freakin out

 Run hashicorp/[email protected]
Error: Unable to find asset matching copywrite_0.16.5_linux_x86_64.tar.gz in the v0.16.5 release

Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vjeffrey

@chris-rock chris-rock merged commit a006762 into main Sep 27, 2023
10 checks passed
@chris-rock chris-rock deleted the vj/awsebscleanup branch September 27, 2023 21:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws ebs scan needs to clean up after the scan is done
2 participants