Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--token in GitHub provider should take precedence over GITHUB_TOKEN #5036

Open
tas50 opened this issue Dec 23, 2024 · 0 comments
Open

--token in GitHub provider should take precedence over GITHUB_TOKEN #5036

tas50 opened this issue Dec 23, 2024 · 0 comments
Assignees

Comments

@tas50
Copy link
Member

tas50 commented Dec 23, 2024

Describe the bug
Command line flags should always come first. Right now if you set a value in the GITHUB_TOKEN env var we will use that even if you provide a CLI --token flag. This can be very confusing and resulted in this PM troubleshooting what was wrong with his token for WAY too long before realizing the mistake. Let's make sure explicit values provided with --token are authoritative.

@tas50 tas50 assigned tas50 and afiune and unassigned tas50 Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants