🧹 Use generic func to convert slices of a type to slices of interface #988
Conversation
Signed-off-by: Ivan Milchev <[email protected]>
imilchev
force-pushed
the
ivan/generic-slice-conversion
branch
from
50a7811 to
de05673
Compare
| res := make([]interface{}, len(value)) | ||
| for i := range value { | ||
| res[i] = value[i] | ||
| func SliceToInterfaceSlice[T any](ss []T) []interface{} { |
There was a problem hiding this comment.
Can we add a simple test case that checks:
- slice of strings to interface
- slide of strings with pointers and nil elements (this has worked before and nil elements where filtered, the new implementation behaves slightly different)
There was a problem hiding this comment.
I added tests. Also made sure the behaviour remains the same although I don't think it's needed. The ptr function was used only in 1 place for azure sql resources. I don't think they return nil entries in slices. It could be that this check was added during development for some testing. Anyways, now the behaviour is identical
There was a problem hiding this comment.
If it is just one place, lets test it without the old behavior and simplify the implementation
There was a problem hiding this comment.
If we want this to be a generic function, I think we should keep the nil checks in place. The signature of that function allows you to pass in an array with nils in it, so we should assume that this can happen, otherwise we're making assumptions about the consumers of that function.
Right now it's used only in the azure stuff which probably will never give you back a nil pointer amongst the other stuff, but maybe 20 new API providers down the road some of those have weird APIs that also give you back nil entries in a list of pointers.
Instead, if you don't wanna keep that generic function then we can get rid of it and just do that conversion in the azure-related code directly
Signed-off-by: Ivan Milchev <[email protected]>
|
@imilchev is that one still up to date. If we want to get this improvement in, we should rebase and add tests for the cases. |
|
We can probably close this? |
doesn't change anything for the end user
Just replaced the
core.StrSliceToInterfacefunc with a generic function that works for slices of any type. We discussed this in #981 (comment)