🐛 fix crash on empty array.flat with missing type info #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can unfortunately still happen, where the type info is missing and we essentially get the array indication in the type field, but nothing else. The subsequent for loop then crashes it. Add testing for this use-case and fix the crash by forcing the any-type into it. Signed-off-by: Dominik Richter <[email protected]>
arlimus
force-pushed
the
dom/array-flat
branch
from
a273c97 to
5252e99
Compare
Test Results744 tests +2 744 ✅ +2 13s ⏱️ -1s Results for commit 5252e99. ± Comparison against base commit 89fb1a1. This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both. |
vjeffrey
approved these changes
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can unfortunately still happen, where the type info is missing and we essentially get the array indication in the type field, but nothing else. The subsequent for loop then crashes it.
Add testing for this use-case and fix the crash by forcing the any-type into it.