Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› fix getting gcp compute subnetworks for a network #3975

Merged
merged 1 commit into from
May 13, 2024

Conversation

imilchev
Copy link
Member

Fixes the following issue:

β†’ selected asset asset=gke-cluster selection=1
β†’ connected to GCP Compute Network
  ___ _ __  ___ _ __   ___  ___ 
 / __| '_ \/ __| '_ \ / _ \/ __|
| (__| | | \__ \ |_) |  __/ (__ 
 \___|_| |_|___/ .__/ \___|\___|
   mondooβ„’     |_|              
cnspec> gcp.compute.network.subnetworks.length
[gcp] cannot set 'region' in resource 'gcp.project.computeService.subnetwork', type does not match
gcp.compute.gcp.project.computeService.network.subnetworks.length: no data available

Now:

β†’ selected asset asset=gke-cluster selection=1
β†’ connected to GCP Compute Network
  ___ _ __  ___ _ __   ___  ___ 
 / __| '_ \/ __| '_ \ / _ \/ __|
| (__| | | \__ \ |_) |  __/ (__ 
 \___|_| |_|___/ .__/ \___|\___|
   mondooβ„’     |_|              
cnspec> gcp.compute.network.subnetworks.length
gcp.compute.gcp.project.computeService.network.subnetworks.length: 1
cnspec> gcp.compute.network.subnetworks
gcp.compute.gcp.project.computeService.network.subnetworks: [
  0: gcp.project.computeService.subnetwork name="gke-cluster-subnet"
]

Copy link
Contributor

Test Results

2β€ˆ989 tests  Β±0   2β€ˆ988 βœ… Β±0   1m 38s ⏱️ +6s
β€‡β€ˆ329 suites Β±0β€‚β€ƒβ€ƒβ€‡β€ˆβ€‡β€‡1 πŸ’€ Β±0 
β€‡β€ˆβ€‡23 files   Β±0β€‚β€ƒβ€ƒβ€‡β€ˆβ€‡β€‡0 ❌ Β±0 

Results for commit b6d4baf. ± Comparison against base commit f7e7764.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.
go.mondoo.com/cnquery/v11/llx ‑ TestSuccess/2024-05-13_08:24:19.335536687_+0000_UTC_m=+0.014999175
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-13_08:24:19.335536687_+0000_UTC_m=+0.014999175
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-13_08:24:19.335536687_+0000_UTC_m=+0.014999175#01
go.mondoo.com/cnquery/v11/llx ‑ TestSuccess/2024-05-13_09:43:30.102154699_+0000_UTC_m=+0.009672601
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-13_09:43:30.102154699_+0000_UTC_m=+0.009672601
go.mondoo.com/cnquery/v11/llx ‑ TestTruthy/2024-05-13_09:43:30.102154699_+0000_UTC_m=+0.009672601#01

@imilchev imilchev merged commit d619bf8 into main May 13, 2024
15 checks passed
@imilchev imilchev deleted the ivan/gcp-network-subnets branch May 13, 2024 12:52
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants