From 4f06128c59722726c6dfffeeefb4f7d5255bc67b Mon Sep 17 00:00:00 2001 From: Ivan Milchev Date: Fri, 2 Feb 2024 16:03:03 +0200 Subject: [PATCH] fix linter errors and make sure runtimes are closed Signed-off-by: Ivan Milchev --- policy/scan/local_scanner.go | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/policy/scan/local_scanner.go b/policy/scan/local_scanner.go index 2a6289b2..182b6340 100644 --- a/policy/scan/local_scanner.go +++ b/policy/scan/local_scanner.go @@ -306,7 +306,10 @@ func discoverAssets(ctx context.Context, job *Job, upstream *upstream.UpstreamCo discoveredAssets.AddError(resolvedRootAsset, err) continue } - rootRuntime.SetRecording(recording) + if err := rootRuntime.SetRecording(recording); err != nil { + discoveredAssets.AddError(resolvedRootAsset, err) + continue + } if err := rootRuntime.Connect(&plugin.ConnectReq{ Features: cnquery.GetFeatures(ctx), @@ -326,6 +329,11 @@ func discoverAssets(ctx context.Context, job *Job, upstream *upstream.UpstreamCo discoveredAssets.AddError(a, err) continue } + if err := runtime.SetRecording(recording); err != nil { + discoveredAssets.AddError(resolvedRootAsset, err) + runtime.Close() + continue + } err = runtime.Connect(&plugin.ConnectReq{ Features: config.Features, @@ -334,6 +342,7 @@ func discoverAssets(ctx context.Context, job *Job, upstream *upstream.UpstreamCo }) if err != nil { discoveredAssets.AddError(a, err) + runtime.Close() continue }