Skip to content

Commit

Permalink
Comments made on a closed PR will fail, workflow should still succeed (
Browse files Browse the repository at this point in the history
…#7)

Signed-off-by: Ben Rockwood <[email protected]>
  • Loading branch information
benr authored Feb 29, 2024
1 parent d48cd4d commit f465fa0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/PREview-create.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
run: gsutil web set -m index.html -e 404.html gs://${BUCKET}
- uses: mshick/add-pr-comment@v2
if: success()
continue-on-error: true
with:
message: |
**PREview environment has been created at [${{ env.URL }}](${{ env.URL }})**
Expand Down Expand Up @@ -77,6 +78,7 @@ jobs:
steps:
- uses: mshick/add-pr-comment@v2
if: success()
continue-on-error: true
with:
message: |
**PREview has been updated at ${{ needs.data.outputs.url }}**
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/PREview-delete.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ jobs:
run: gsutil rm -r gs://${BUCKET}
- uses: mshick/add-pr-comment@v2
if: success()
continue-on-error: true
with:
message: |
**PREview environment deleted.**
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/PREview-update.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ jobs:
steps:
- uses: mshick/add-pr-comment@v2
if: success()
continue-on-error: true
with:
message: |
**PREview has been updated at ${{ needs.data.outputs.url }}**
Expand Down

0 comments on commit f465fa0

Please sign in to comment.