🐛 fix validation for daemonset node scans

Signed-off-by: Ivan Milchev <[email protected]>
mondoohq · Sep 18, 2024 · 35563f3 · 35563f3
1 parent 3c263ff
commit 35563f3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/api/v1alpha2/mondooauditconfig_types.go b/api/v1alpha2/mondooauditconfig_types.go
@@ -110,7 +110,7 @@ type Nodes struct {
 	// +kubebuilder:default=60
 	IntervalTimer int `json:"intervalTimer,omitempty"`
 	// Style specifies how node scanning is deployed. The default is "cronjob" which will create a CronJob for the node scanning.
-	// +kubebuilder:validation:Enum=cronjob;deployment
+	// +kubebuilder:validation:Enum=cronjob;deployment;daemonset
 	// +kubebuilder:default=cronjob
 	Style NodeScanStyle `json:"style,omitempty"`
 	// PriorityClassName specifies the name of the PriorityClass for the node scanning workloads.

diff --git a/config/crd/bases/k8s.mondoo.com_mondooauditconfigs.yaml b/config/crd/bases/k8s.mondoo.com_mondooauditconfigs.yaml
@@ -538,6 +538,7 @@ spec:
                     enum:
                     - cronjob
                     - deployment
+                    - daemonset
                     type: string
                 type: object
               scanner:

diff --git a/tests/integration/audit_config_test.go b/tests/integration/audit_config_test.go
@@ -48,7 +48,7 @@ func (s *AuditConfigSuite) TestReconcile_Nodes_CronJobs() {
 
 func (s *AuditConfigSuite) TestReconcile_Nodes_DaemonSet() {
 	auditConfig := utils.DefaultAuditConfigMinimal(s.testCluster.Settings.Namespace, false, false, true, false)
-	auditConfig.Spec.Nodes.Style = v1alpha2.NodeScanStyle_Deployment // TODO: Change to DaemonSet (no effect on reconsile logic)
+	auditConfig.Spec.Nodes.Style = v1alpha2.NodeScanStyle_DaemonSet
 	auditConfig.Spec.Nodes.IntervalTimer = 1
 	s.testMondooAuditConfigNodesDaemonSets(auditConfig)
 }