Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear semantic of skipContainerResolution flag #474

Open
chris-rock opened this issue Jul 28, 2022 · 0 comments
Open

Unclear semantic of skipContainerResolution flag #474

chris-rock opened this issue Jul 28, 2022 · 0 comments

Comments

@chris-rock
Copy link
Member

What is not working as you expected it?

When we

apiVersion: k8s.mondoo.com/v1alpha2
kind: MondooOperatorConfig
metadata:
  name: mondoo-operator-config
spec:
  skipContainerResolution: true

For the MondooOperatorConfig we use skipContainerResolution to enable/disable the digest resolution for images. The current name can be misinterpreted as disabling Container resolution from pods which can be enabled/disabled in the MondooAuditConfig

Where on the platform does it happen?

all

How do we replicate the issue?

see above

Expected behavior (i.e. solution)

We should use a more descriptive name like skipImageDigestResolution to avoid confusion with settings in the MondooAuditConfig

Other Comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant