-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⭐️ add support for using http proxies #859
Conversation
imilchev
commented
Sep 20, 2023
- Make sure the proxy is used by cnspec
- make sure the operator uses the proxy too when reporting status upstream
eaabe1c
to
c68fd21
Compare
This PR solves #853 |
For testing, I used network policies to limit the traffic. I came across these messages for the image scan:
This client is not taking up the proxy. But I'm not sure whether this was intended by the request. The linked issue only mentions the API proxy. |
For some scans, I see the requests in the proxy logs and also the assets in the console. |
Signed-off-by: Ivan Milchev <[email protected]>
…onfig Signed-off-by: Ivan Milchev <[email protected]>
Signed-off-by: Ivan Milchev <[email protected]>
Signed-off-by: Ivan Milchev <[email protected]>
Signed-off-by: Ivan Milchev <[email protected]>
55e8821
to
8724a09
Compare
Signed-off-by: Ivan Milchev <[email protected]>
During a test, I had an error in my setup. But nice to see we get a meaningful error message:
|
Node scan is now also working via proxy:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @imilchev