Hook refreshOptions instead of onFocus #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selectize.js refreshes the DOM list of clickable options frequently, such as after any option is selected, and when the user types to filter the list of options. The plugin needs to reapply the disabled class after every one of those events, which it can do by running its extra code after every call to refreshOptions. Fixes mondorobot#3.
added 3 commits
February 12, 2017 19:15
The plugin's definition of onOptionSelect only needs to provide the new behavior for handling disabled options, and should fall through to the underlying implementation for the create/select choices rather than copy-and-pasting that code into the plugin. This is important so that when fixes are made in Selectize.js they don't need to be replicated here.
The initial version of this plugin only allowed disabled options to be set when a Selectize instance was created, but in some circumstances you may need to disable choices on the fly. This change adds four new methods to the API to allow this: - disableOptions(values): Add the provided values to the disabled list. - enableOptions(values): Remove the provided values to the disabled list. - setDisabledOptions(values): Make the provided values the only ones disabled. - disabledOptions(): Retrieve an array of the disabled options. This is similar to @ghost/734537b6947a1b85ac07ec934a749b4d4d43fa35 but just contains new methods without overwriting any of the original module. Fixes mondorobot#2.
Disabled options shouldn't be highlighted the same way as regular options when made active by mouseover or arrow-key selection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selectize.js refreshes the DOM list of clickable options frequently,
such as after any option is selected, and when the user types to filter
the list of options.
The plugin needs to reapply the disabled class after every one of those
events, which it can do by running its extra code after every call to
refreshOptions.
Fixes #3.