GMP error when comparing fractions (#598)

* Add failing test GmpCalculatorTest::it_compares_zero_with_fraction() * Fix GmpCalculator::compare() when comparing fractions less than 1
moneyphp · Mar 18, 2020 · 122664c · 122664c
1 parent 0415ec9
commit 122664c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Calculator/GmpCalculator.php b/src/Calculator/GmpCalculator.php
@@ -46,7 +46,10 @@ public function compare($a, $b)
                 return $integersCompared;
             }
 
-            return gmp_cmp($aNum->getFractionalPart(), $bNum->getFractionalPart());
+            $aNumFractional = $aNum->getFractionalPart() === '' ? '0' : $aNum->getFractionalPart();
+            $bNumFractional = $bNum->getFractionalPart() === '' ? '0' : $bNum->getFractionalPart();
+
+            return gmp_cmp($aNumFractional, $bNumFractional);
         }
 
         return gmp_cmp($a, $b);

diff --git a/tests/Calculator/GmpCalculatorTest.php b/tests/Calculator/GmpCalculatorTest.php
@@ -29,4 +29,12 @@ public function it_floors_zero()
     {
         $this->assertSame('0', $this->getCalculator()->floor('0'));
     }
+
+    /**
+     * @test
+     */
+    public function it_compares_zero_with_fraction()
+    {
+        $this->assertSame(1, $this->getCalculator()->compare('0.5', '0'));
+    }
 }