-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A long delay in auto frame rate matching #632
Comments
The app needs to read enough video track samples to get the average frame rate. I set it to 1000 samples to get good enough precision. But I can lower it to 350 which is just above the limit if I look for commonly used frame rates (59.94 vs 60 fps). Let's try version from https://brouken.com/player/ if it still works as expected. Hopefully it should get rid of almost 2/3 of the delay. |
It's now quite good on most files taking about 2-5 seconds but still not as good as 0.181 obviously. One 23.976 fps movie I tried to play still takes 10 to 15 seconds until it switches the frame rate. I also thought you removed auto-play and that's why I manually pressed play right away but it seems that when it gets the frame rate it will play back automatically so that makes the issue a bit less severe. Was the FFmpeg dependency too laborious to maintain or why was it removed? |
FFmpeg is available as ready made library so maintenance wasn't a problem. The problem was size and principle. Without FFmpeg, the app is only 15 MB while adding FFmpeg, useful only for frame rate detection additional 55 MB. It packs all the decoders/encoders and it wasn't only ffprobe. It could probably be trimmed down, but that would be additional burden. All of this shouldn't be needed as modern Android (12+) devices can change refresh rates without switching display modes. ExoPlayer already uses by default the |
Try https://brouken.com/player/frame_rate_strategy/ Does it switches display refresh rate at all? It ignores auto frame rate matching settings and attempts to set |
I managed to upgrade my Xiaomi Mi Box S to Android 12. Seems like that the |
No, it doesn't switch display refresh rate at all. |
Yep. In my case the display was switching because of HDR and not refresh rate. Seems like the |
Describe the bug
There's a long delay, usually about 10 to 20 seconds, before display matches with a video frame rate. This started in v0.182 when an FFmpeg dependency was removed. Before it was pretty much instant.
Device (please complete the following information):
The text was updated successfully, but these errors were encountered: