Skip to content

INTPYTHON-591 Add pymongo-voyageai to pipeline #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 30, 2025

Conversation

blink1073
Copy link
Member

@blink1073 blink1073 commented Apr 30, 2025

@blink1073 blink1073 requested a review from caseyclements April 30, 2025 02:13
Copy link
Collaborator

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
One question about introduction of [AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN]. Blob storage only, right? Nothing to do with BedRock?

"execute tests":
- command: subprocess.exec
type: test
params:
include_expansions_in_env: [DIR]
include_expansions_in_env: [DIR, AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this simply for the introduction of blob storage? This has nothing to do with Bedrock, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be used for either. For right now it is for S3 access.

@blink1073 blink1073 merged commit 72f26f8 into mongodb-labs:main Apr 30, 2025
11 of 13 checks passed
@blink1073 blink1073 deleted the add-voyageai branch April 30, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants