-
Notifications
You must be signed in to change notification settings - Fork 5
INTPYTHON-591 Add pymongo-voyageai to pipeline #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
One question about introduction of [AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN]. Blob storage only, right? Nothing to do with BedRock?
"execute tests": | ||
- command: subprocess.exec | ||
type: test | ||
params: | ||
include_expansions_in_env: [DIR] | ||
include_expansions_in_env: [DIR, AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this simply for the introduction of blob storage? This has nothing to do with Bedrock, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be used for either. For right now it is for S3 access.
Passing build: https://spruce.mongodb.com/version/681185aff7c84b0007136c28/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC