Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a separate step for pypi upload #62

Closed
blink1073 opened this issue Nov 7, 2024 · 1 comment · Fixed by #69
Closed

Use a separate step for pypi upload #62

blink1073 opened this issue Nov 7, 2024 · 1 comment · Fixed by #69

Comments

@blink1073
Copy link
Member

The author of gh-action-pypi-publish does not intend to support nested usage of the action, so we'll have to switch to something manual. pypa/gh-action-pypi-publish#290. We have a script in drivers-evergreen-tools that we can copy from.
@blink1073 blink1073 mentioned this issue Nov 7, 2024
Merged
@blink1073
Copy link
Member Author

Actually, a better approach is to do as they recommend and make it a top level action. I think we should wait until pypa/gh-action-pypi-publish#288 lands, and remove GitHub Attestations and PyPI publishing.

@blink1073 blink1073 mentioned this issue Dec 30, 2024
Merged
@blink1073 blink1073 changed the title Use a custom action to upload python packages Use a separate step for pypi upload Dec 30, 2024
@blink1073 blink1073 mentioned this issue Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make python publish a separate job blink1073/drivers-github-tools
1 participant
@blink1073