Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-43442 - Add Python 3.13 #990

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

mongoKart
Copy link
Contributor

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43442
Staging - https://preview-mongodbmongokart.gatsbyjs.io/drivers/docsp-43442-python-version/motor/#language-compatibility

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for docs-ecosystem failed. Why did it fail? →

Name Link
🔨 Latest commit f245869
🔍 Latest deploy log https://app.netlify.com/sites/docs-ecosystem/deploys/66e4596a9aebad0008981efa

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tech reviewer: What version(s) of the driver does Motor 3.6 wrap?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wraps version 4.9. Also, we should add MongoDB 8.0 to the list of supported Databases, and remove Database versions prior to 3.6. This version is compatible with 3.6-8.0.

Copy link
Contributor Author

@mongoKart mongoKart Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blink1073 For MongoDB 8.0, should previous Motor versions be marked incompatible or partially compatible? See docs here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they are partially compatible.

Copy link
Contributor

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mongoKart mongoKart requested a review from blink1073 September 12, 2024 19:43
@mongoKart mongoKart merged commit 2571ca7 into mongodb:master Sep 13, 2024
1 of 5 checks passed
@mongoKart mongoKart deleted the docsp-43442-python-version branch September 13, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants