Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCSP-43819: php 1.20 release #991

Merged
merged 3 commits into from
Sep 26, 2024
Merged

DOCSP-43819: php 1.20 release #991

merged 3 commits into from
Sep 26, 2024

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Sep 26, 2024 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43819
Staging - https://deploy-preview-991--docs-ecosystem.netlify.app/php-drivers/#compatibility

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Sep 26, 2024 •
edited
Loading

✅ Deploy Preview for docs-ecosystem ready!

Name Link
🔨 Latest commit c6b6af2
🔍 Latest deploy log https://app.netlify.com/sites/docs-ecosystem/deploys/66f59c383af568000823de5c
😎 Deploy Preview https://deploy-preview-991--docs-ecosystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rustagir
rustagir commented Sep 26, 2024
View reviewed changes
source/includes/language-compatibility-table-php.rst
@@ -16,6 +16,19 @@
- PHP 5.6
- PHP 5.5

* - ext + lib 1.20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/mongodb/docs-php-library/blob/php-standardization/source/includes/language-compatibility-table-php.rst

mongoKart
mongoKart approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. doesn't need to be this ticket, but at some point we should ask if we're still supporting those really old driver versions

@rustagir rustagir merged commit dc86ea6 into mongodb:master Sep 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mongoKart mongoKart mongoKart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rustagir @mongoKart