-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension-improvements implement support for addFunctions method #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for search-manifest-integration failed. Why did it fail? →
|
❌ Deploy Preview for site-links-display failed. Why did it fail? →
|
✅ Deploy Preview for persistence-module-ext canceled.
|
✅ Deploy Preview for git-changed-file-extension canceled.
|
❌ Deploy Preview for search-manifest-extension failed. Why did it fail? →
|
✅ Deploy Preview for snooty-cache-extension canceled.
|
✅ Deploy Preview for populate-data-extension canceled.
|
❌ Deploy Preview for test-monorepo-redoc failed. Why did it fail? →
|
❌ Deploy Preview for redoc-ext-test failed. Why did it fail? →
|
branberry
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small change to the Extensions class we've created that extends the NetlifyExtensions class. It implements an override for NetlifyExtension's
addFunctions
method similar to that of the overridenaddBuildEventHandler
method; both will only run on Netlify sites for which the enablement variable passed into the extension is set totrue