Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension-improvements implement support for addFunctions method #36

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

anabellabuckvar
Copy link
Collaborator

This PR is a small change to the Extensions class we've created that extends the NetlifyExtensions class. It implements an override for NetlifyExtension's addFunctions method similar to that of the overridenaddBuildEventHandler method; both will only run on Netlify sites for which the enablement variable passed into the extension is set to true

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for search-manifest-integration failed. Why did it fail? →

Name Link
🔨 Latest commit 8dfa2c4
🔍 Latest deploy log https://app.netlify.com/sites/search-manifest-integration/deploys/6734de8e742932000888d6b4

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for site-links-display failed. Why did it fail? →

Name Link
🔨 Latest commit 8dfa2c4
🔍 Latest deploy log https://app.netlify.com/sites/site-links-display/deploys/6734de8e050ee60008c15559

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for persistence-module-ext canceled.

Name Link
🔨 Latest commit 8dfa2c4
🔍 Latest deploy log https://app.netlify.com/sites/persistence-module-ext/deploys/6734de8eab365b0008527b10

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for git-changed-file-extension canceled.

Name Link
🔨 Latest commit 8dfa2c4
🔍 Latest deploy log https://app.netlify.com/sites/git-changed-file-extension/deploys/6734de8eab365b0008527b0c

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for search-manifest-extension failed. Why did it fail? →

Name Link
🔨 Latest commit 8dfa2c4
🔍 Latest deploy log https://app.netlify.com/sites/search-manifest-extension/deploys/6734de8e7f29d600090f531b

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for snooty-cache-extension canceled.

Name Link
🔨 Latest commit 8dfa2c4
🔍 Latest deploy log https://app.netlify.com/sites/snooty-cache-extension/deploys/6734de8ead23f20008f9d120

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for populate-data-extension canceled.

Name Link
🔨 Latest commit 8dfa2c4
🔍 Latest deploy log https://app.netlify.com/sites/populate-data-extension/deploys/6734de8e742932000888d6b9

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for test-monorepo-redoc failed. Why did it fail? →

Name Link
🔨 Latest commit 8dfa2c4
🔍 Latest deploy log https://app.netlify.com/sites/test-monorepo-redoc/deploys/6734de8e4c7e7f00086f5db8

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for redoc-ext-test failed. Why did it fail? →

Name Link
🔨 Latest commit 8dfa2c4
🔍 Latest deploy log https://app.netlify.com/sites/redoc-ext-test/deploys/6734de8ead23f20008f9d11e

Copy link
Collaborator

@branberry branberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anabellabuckvar anabellabuckvar merged commit 2a20815 into main Nov 13, 2024
16 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants