DOP-5023: Netlify Integration Calls Mut-Redirects #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for mut-connector failed. Why did it fail? →
|
✅ Deploy Preview for redoc-integration canceled.
|
✅ Deploy Preview for site-links-display canceled.
|
✅ Deploy Preview for snooty-cache-plugin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for persistence-module-integration canceled.
|
✅ Deploy Preview for search-manifest-integration canceled.
|
❌ Deploy Preview for git-changed-files-plugin-bianca failed. Why did it fail? →
|
anabellabuckvar
changed the title
✅ Deploy Preview for git-changed-files-plugin-bianca canceled.
|
i80and
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET
DOP-5023
NOTES
This PR adds another build event handler to the existing snooty-cache Netlify integration. This new build event handler downloads Mut and calls Mut-redirects, which creates an .htaccess file derived from the content repo's config/redirects file. This file will be used to by mut-publish as will be implemented in DOP-5022.
This code should live in its own Netlify integration/extension but this can be done in a separate PR at a later date- Netlify is set to do a big release to their SDK on 10/2 or 10/3 and at which point they will enable migration to "extensions" from "integrations".
TESTING
A docs-node-branfork build with this branch of this integration:
https://app.netlify.com/sites/docs-node-branfork/deploys/66f58400f940d62eb99b6aa9
On line 2947 of the logs we can see that an .htaccess file has been created (the logging statement responsible for this output has been removed so that the PR is merge-ready)