Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require rgeo-geojson with rgeo for easier conversions and wider support? #67

Open
camiloforero opened this issue Oct 18, 2018 · 2 comments

Comments

@camiloforero
Copy link

As the title says, I propose that if an user wants to install this gem with rgeos support, they will also be required to install the rgeos-geojson package.

If we do that, then we can replace the whole rgeo.rb wrapper by calls to this library, which has more built-in robustness and a variety of functions already implemented.

And this will make it much easier to add support to MultiPoint, MultiLineString and MultiPolygon classes in the future, as they are already supported by that library.

Would this kind of change and additional optional dependency be ok?

@dblock
Copy link
Collaborator

dblock commented Oct 18, 2018

Sounds good to me.

@camiloforero
Copy link
Author

Cool! I can start working on that then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants