Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrumentation know how and span json - user guide update #14

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

oi-raanne
Copy link
Contributor

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [x ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [x ] I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • [x ] I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@oi-raanne oi-raanne force-pushed the raanne/user_guide_span_json branch from 4d0fb8d to b892d5f Compare July 17, 2024 17:42
@oi-raanne oi-raanne force-pushed the raanne/user_guide_span_json branch from 05b6316 to 56aa0e4 Compare July 17, 2024 17:53
@prasad-okahu
Copy link
Contributor

@oi-raanne Contents look fine to me. Thanks for putting this together. Got a few minor suggestions on the format and some additional description. Instead of adding those as comments and more iterations, I'll create a new pull request for those. Thanks

@prasad-okahu prasad-okahu merged commit 85adf48 into main Jul 18, 2024
5 checks passed
@prasad-okahu prasad-okahu deleted the raanne/user_guide_span_json branch July 18, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants