Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Llama index bugs #32

Merged
merged 4 commits into from
Aug 27, 2024
Merged

Fixed Llama index bugs #32

merged 4 commits into from
Aug 27, 2024

Conversation

kshitiz-okahu
Copy link
Contributor

Proposed changes

Fixed tow bugs related to llamaindex.

  • Fixed bug where monocle will not instrument code langchain package is not installed.
  • Fixed bug where token usage for llamaindex wrapper code would throw error. The code is modifieed to catch error and also updated to extract the tokens info correctly.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
@kshitiz-okahu kshitiz-okahu changed the title fixed llama index bugs Fixed Llama index bugs Aug 27, 2024
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
src/monocle_apptrace/wrap_common.py Outdated Show resolved Hide resolved
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
Signed-off-by: Kshitiz Vijayvargiya <[email protected]>
@kshitiz-okahu kshitiz-okahu merged commit 8556cc6 into main Aug 27, 2024
6 checks passed
@kshitiz-okahu kshitiz-okahu deleted the kshitiz/fix_bugs branch November 13, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants