Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metamodel updates #54

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

prasad-okahu
Copy link
Contributor

Added model name to type and updated docs

Proposed changes

  • Update metamodel docs
  • Removed the entity instances eg types of inference services, vectorDBs etc from the core entity definition and created them as separate list of types.
  • The entity type is now entity[.category.]type, eg inference.openai or model.llm.gpt-35-turbo

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...


### MonocleEntity.Workflow
Workflow ie the core application code. Supported types are -
Workflow ie the core application code.
#### Workflow types
- generic
- langchain
- llama_index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

llamaindex is a single word as seen on their official page
https://www.llamaindex.ai/

@prasad-okahu prasad-okahu changed the title metamode updates metamodel updates Oct 17, 2024
@prasad-okahu
Copy link
Contributor Author

Updates per review feedback

"entity" : "workflow",
"types": [
{
"name": "llama_index",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling: llamaindex

Added model name to type and updated docs

Signed-off-by: Prasad Mujumdar <[email protected]>
Signed-off-by: Prasad Mujumdar <[email protected]>
@prasad-okahu prasad-okahu force-pushed the metamode-updates.prasad branch from ff45131 to 8403492 Compare October 17, 2024 18:12
@prasad-okahu prasad-okahu merged commit 94fa87d into monocle2ai:main Oct 17, 2024
6 checks passed
@prasad-okahu prasad-okahu deleted the metamode-updates.prasad branch October 17, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants