Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capturing vectorstore deployment url #80

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

sachintendulkar576123
Copy link
Contributor

@sachintendulkar576123 sachintendulkar576123 commented Nov 26, 2024

Proposed changes

This PR:

  • we are capturing the vector deployment url for OpenSearch vectorstore

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Signed-off-by: sachintendulkar576123 <[email protected]>
src/monocle_apptrace/utils.py Outdated Show resolved Hide resolved
src/monocle_apptrace/utils.py Outdated Show resolved Hide resolved
Signed-off-by: sachintendulkar576123 <[email protected]>
Signed-off-by: sachintendulkar576123 <[email protected]>
@oi-raanne
Copy link
Contributor

unit tests missing

src/monocle_apptrace/utils.py Outdated Show resolved Hide resolved
src/monocle_apptrace/utils.py Outdated Show resolved Hide resolved
src/monocle_apptrace/utils.py Outdated Show resolved Hide resolved
src/monocle_apptrace/utils.py Show resolved Hide resolved
src/monocle_apptrace/utils.py Outdated Show resolved Hide resolved
src/monocle_apptrace/utils.py Outdated Show resolved Hide resolved
Signed-off-by: sachintendulkar576123 <[email protected]>
@oi-raanne oi-raanne merged commit b17c2d1 into monocle2ai:main Nov 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants