Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP version #89

Open
gaborpapp opened this issue Aug 12, 2021 · 4 comments
Open

TCP version #89

gaborpapp opened this issue Aug 12, 2021 · 4 comments

Comments

@gaborpapp
Copy link

As far as I know it's UDP only. Would it be possible to add TCP support?

@monsieurgustav
Copy link
Owner

Hi Gaborapp,
Indeed it is currently UDP only, as OSC generally is.
Adding support for TCP is largely doable, but I have no plan to code it myself.

@gaborpapp
Copy link
Author

Thanks. Would you accept a pull request about this?
As I see it now oscpack can be replaced with liblo that supports TCP.

@monsieurgustav
Copy link
Owner

Yes, I would accept a PR!
Some recommandations:

  • there should be a setting to choose UDP vs TCP, defaulting to UDP.
  • oscpack is used only to write/parse OSC messages, not to send/receive them. I used the UE4 network functions instead. So the TCP connections should be established using the UE4 functions too. I'm not inclined to replace oscpack.
  • I guess some new events are needed (connected, disconnected, etc.). I would prefix them with "TCP" so that people do not expect them to work when using UDP.

@monsieurgustav
Copy link
Owner

Several years later...
7e99bb8 adds a DispatchPacket method. I use it to plug this plugin with the nDisplay event system, but that would work to receive from TCP too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants