From 22388f8467d2cd0c852333c82e1c508af142a93d Mon Sep 17 00:00:00 2001 From: montag451 Date: Tue, 14 Jan 2014 22:58:17 +0100 Subject: [PATCH] Fix a bug in the checking of the return value of inet_aton --- pytun.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pytun.c b/pytun.c index 4bcd3cc..0c046d0 100644 --- a/pytun.c +++ b/pytun.c @@ -243,7 +243,7 @@ static int pytun_tuntap_set_addr(PyObject* self, PyObject* value, void* d) strcpy(req.ifr_name, tuntap->name); sin = (struct sockaddr_in*)&req.ifr_addr; sin->sin_family = AF_INET; - if (inet_aton(addr, &sin->sin_addr) < 0) + if (inet_aton(addr, &sin->sin_addr) == 0) { raise_error("Bad IP address"); ret = -1; @@ -315,7 +315,7 @@ static int pytun_tuntap_set_dstaddr(PyObject* self, PyObject* value, void* d) strcpy(req.ifr_name, tuntap->name); sin = (struct sockaddr_in*)&req.ifr_dstaddr; sin->sin_family = AF_INET; - if (inet_aton(dstaddr, &sin->sin_addr) < 0) + if (inet_aton(dstaddr, &sin->sin_addr) == 0) { raise_error("Bad IP address"); ret = -1; @@ -438,7 +438,7 @@ static int pytun_tuntap_set_netmask(PyObject* self, PyObject* value, void* d) strcpy(req.ifr_name, tuntap->name); sin = (struct sockaddr_in*)&req.ifr_netmask; sin->sin_family = AF_INET; - if (inet_aton(netmask, &sin->sin_addr) < 0) + if (inet_aton(netmask, &sin->sin_addr) == 0) { raise_error("Bad IP address"); ret = -1;